Use pinned Hermes version when version.properties is not 1000.0.0#56607
Merged
cipolleschi merged 4 commits into0.85-stablefrom Apr 24, 2026
Merged
Use pinned Hermes version when version.properties is not 1000.0.0#56607cipolleschi merged 4 commits into0.85-stablefrom
cipolleschi merged 4 commits into0.85-stablefrom
Conversation
The use-hermes-nightly flag was computed from the branch name, which evaluates incorrectly for PR branches targeting stable. Instead, read the actual HERMES_VERSION_NAME from version.properties and only use nightly when it is the 1000.0.0 development placeholder.
meta-cla
Bot
added
the
CLA Signed
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
The Hermes version is now derived from version.properties directly, so the use-hermes-nightly input and all caller references are no longer needed.
The Maven Central artifact version uses the hermes-v prefix (e.g. hermes-v250829098.0.10), but the version.properties file stores the raw version number. Add the prefix when constructing the HERMES_VERSION env var so the prebuild script finds the artifact.
The Maven Central artifact uses the raw version number (e.g. 250829098.0.10), not the hermes-v prefixed form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_VERSION_NAME/HERMES_V1_VERSION_NAMEfromversion.propertiesto decide whether to use nightly Hermes, instead of relying on the branch name.use-hermes-nightly.jsor setslatest-v1when the version is1000.0.0(the development placeholder).This is the 0.85-stable backport of the same fix applied to 0.83-stable.
Changelog:
[Internal] - Fix CI
Test plan
version.propertiesrather than falling back to nightly.